Skip to content

Preparing for Combine #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Preparing for Combine #4

merged 7 commits into from
Aug 11, 2021

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Aug 10, 2021

PR's key points

  • Clean code
  • Bump to iOS 14
  • Prepare to dispatch actions without mode (always async)
  • Extends Store in order to conform Publisher and prepare migration to Combine. Still conforming ObservableType for legacy support.

@sebastianvarela sebastianvarela added the enhancement New feature or request label Aug 10, 2021
@sebastianvarela sebastianvarela self-assigned this Aug 10, 2021
@sebastianvarela sebastianvarela changed the title Task/update arch Update arch Aug 10, 2021
@sebastianvarela sebastianvarela marked this pull request as ready for review August 11, 2021 12:03
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #4 (84461ff) into master (9e30f27) will decrease coverage by 13.43%.
The diff coverage is 51.85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #4       +/-   ##
===========================================
- Coverage   62.12%   48.68%   -13.44%     
===========================================
  Files          23       19        -4     
  Lines         697      571      -126     
===========================================
- Hits          433      278      -155     
- Misses        264      293       +29     
Flag Coverage Δ
ios ?
mac 48.68% <51.85%> (-13.44%) ⬇️
tv ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/ActionReducer.swift 100.00% <ø> (ø)
Sources/StateType.swift 0.00% <0.00%> (ø)
...ces/Utils/Foundation/DispatchQueueExtensions.swift 0.00% <0.00%> (ø)
Sources/Utils/PayloadAction.swift 0.00% <0.00%> (ø)
...urces/Utils/RxSwift/ObservableTypeExtensions.swift 0.00% <0.00%> (ø)
...tils/RxSwift/PrimitiveSequenceTypeExtensions.swift 0.00% <0.00%> (ø)
Sources/Utils/OrderedSet.swift 62.16% <37.50%> (ø)
Sources/Utils/Combine/DemandBuffer.swift 50.00% <50.00%> (ø)
Sources/Dispatcher.swift 71.17% <55.17%> (ø)
Sources/KeyedTask.swift 62.50% <62.50%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de0b128...84461ff. Read the comment docs.

@ThorBot
Copy link

ThorBot commented Aug 11, 2021

2 Warnings
⚠️ Big PR, try to keep changes smaller if you can 😜
⚠️ SwiftLint not installed, run: brew install swiftlint
6 Messages
📖 📢 [iOS] Executed 25 tests, with 0 failures (0 unexpected) in 3.081 (3.094) seconds
📖 📢 [mac] Executed 25 tests, with 0 failures (0 unexpected) in 3.026 (3.036) seconds
📖 📢 [tv] Executed 25 tests, with 0 failures (0 unexpected) in 3.080 (3.094) seconds
📖 ⌛️ [iOS] Slowest test: test_success_task_with_expiration_setted took 3.011 seconds
📖 ⌛️ [mac] Slowest test: test_success_task_with_expiration_setted took 3.011 seconds
📖 ⌛️ [tv] Slowest test: test_success_task_with_expiration_setted took 3.012 seconds

SwiftLint found issues

Warnings

File Line Reason
DispatcherTests.swift 25 Types should be nested at most 1 level deep (nesting)
ChainTests.swift 6 Types should be nested at most 1 level deep (nesting)

Generated by 🚫 Danger

@sebastianvarela sebastianvarela changed the title Update arch Preparing for Combine Aug 11, 2021
@sebastianvarela sebastianvarela merged commit 794bf88 into master Aug 11, 2021
@sebastianvarela sebastianvarela deleted the task/update_arch branch August 11, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants