Skip to content

Add SPM support and remove Cocoapods #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
664f238
Add SPM support
adrianrl Nov 8, 2024
0bde75e
Delete fastlane, cocoapods and Xcode project files
adrianrl Nov 8, 2024
601f874
Exclude non swift files from project
adrianrl Nov 11, 2024
2be09a5
Update build and tests action
adrianrl Nov 21, 2024
d7f1a60
Run also on ubuntu
adrianrl Nov 21, 2024
a48f3b6
Switch to ubuntu
adrianrl Nov 21, 2024
f843b39
Remote brew and mint
adrianrl Nov 21, 2024
2f65f7f
Remove overcommit and Danger
adrianrl Nov 21, 2024
a85a00d
Fix typo
adrianrl Nov 21, 2024
7f2f4d4
Switch back to apps-ci runner
adrianrl Nov 21, 2024
26b8a1c
Force a test failure
adrianrl Nov 21, 2024
f1aa34b
Green tests again and remove verbose mode
adrianrl Nov 21, 2024
a6f056f
Add swiftlint
sebastianvarela Apr 4, 2025
2d9cd71
bump upload artifacts
sebastianvarela Apr 4, 2025
d7ee3cc
Run swiftlint and put logs on action
sebastianvarela Apr 4, 2025
4f2b187
now
sebastianvarela Apr 4, 2025
eed23db
forgot run
sebastianvarela Apr 4, 2025
7d6ae87
invalid rule
sebastianvarela Apr 4, 2025
494af16
Another try
sebastianvarela Apr 4, 2025
368aaf8
Try if swiftlint stop the build
sebastianvarela Apr 4, 2025
0cfb828
Lint!
sebastianvarela Apr 4, 2025
32a1f5a
bump coverage
sebastianvarela Apr 4, 2025
fa57772
lint
sebastianvarela Apr 4, 2025
d30beab
Try
sebastianvarela Apr 7, 2025
591c345
Try 2
sebastianvarela Apr 7, 2025
e57762f
try3
sebastianvarela Apr 7, 2025
5bf1bec
try 4
sebastianvarela Apr 7, 2025
3bdb698
try ubuntu
sebastianvarela Apr 7, 2025
6b7a37c
back to mac
sebastianvarela Apr 7, 2025
d0eec73
finish
sebastianvarela Apr 7, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .bundle/config

This file was deleted.

90 changes: 0 additions & 90 deletions .github/workflows/build-and-tests.yml

This file was deleted.

69 changes: 69 additions & 0 deletions .github/workflows/pr_validator.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: "pr-validator"
on:
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

jobs:
swiftlint:
name: Swiftlint
runs-on: apps-ci
timeout-minutes: 120
steps:

- name: Checkout 🔎
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Rake ⚙️
run: rake

- name: Swiftlint 👀
run: |
set -o pipefail && mint run swiftlint --strict \
| sed -E 's/^(.*):([0-9]+):([0-9]+): (warning|error|[^:]+): (.*)/::\4 file=\1,line=\2,col=\3::\5/'

build:
name: Test
runs-on: apps-ci
timeout-minutes: 120
steps:

- name: Checkout 🔎
uses: actions/checkout@v3
with:
fetch-depth: 0

- name: Rake ⚙️
run: rake

- name: Run tests ⚙️
run: rake test

- name: Generate lcov file 📈
run: |
xcrun llvm-cov export \
-format="lcov" \
--ignore-filename-regex=".build|.test-bundle|Tests/" \
.build/debug/MiniPackageTests.xctest/Contents/MacOS/MiniPackageTests \
-instr-profile .build/debug/codecov/default.profdata \
> report.lcov

- name: Upload package tests coverage to Codecov 📋
uses: codecov/codecov-action@v3.1.1
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: report.lcov
flags: package
fail_ci_if_error: true
name: codecov-package
gcov_ignore: Tests/*

- name: Save Output 📦
uses: actions/upload-artifact@v4
with:
name: output
path: ${{ github.workspace }}/report.lcov
90 changes: 39 additions & 51 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,18 +1,27 @@
.gems
output/
.DS_Store
Brewfile.lock.json

# Created by https://www.gitignore.io/api/swift,xcode,carthage
# Created by https://www.toptal.com/developers/gitignore/api/swift
# Edit at https://www.toptal.com/developers/gitignore?templates=swift

### Swift ###
# Xcode
#
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore

## Build generated
## User settings
xcuserdata/

## compatibility with Xcode 8 and earlier (ignoring not required starting Xcode 9)
*.xcscmblueprint
*.xccheckout

## compatibility with Xcode 3 and earlier (ignoring not required starting Xcode 4)
build/
DerivedData/

## Various settings
*.moved-aside
*.pbxuser
!default.pbxuser
*.mode1v3
Expand All @@ -21,14 +30,11 @@ DerivedData/
!default.mode2v3
*.perspectivev3
!default.perspectivev3
xcuserdata/

## Other
*.moved-aside
*.xcuserstate

## Obj-C/Swift specific
*.hmap

## App packaging
*.ipa
*.dSYM.zip
*.dSYM
Expand All @@ -38,68 +44,50 @@ timeline.xctimeline
playground.xcworkspace

# Swift Package Manager
#
# Add this line if you want to avoid checking in source code from Swift Package Manager dependencies.
# Packages/
# Package.pins
# Package.resolved
# *.xcodeproj
# Xcode automatically generates this directory with a .xcworkspacedata file and xcuserdata
# hence it is not needed unless you have added a package configuration file to your project
.swiftpm

.build/

# CocoaPods
#
# We recommend against adding the Pods directory to your .gitignore. However
# you should judge for yourself, the pros and cons are mentioned at:
# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
#
# Pods/
# Add this line if you want to avoid checking in source code from the Xcode workspace
# *.xcworkspace

# Carthage
#
# Add this line if you want to avoid checking in source code from Carthage dependencies.
# Carthage/Checkouts

Carthage/
Carthage/Build/

# Accio dependency management
Dependencies/
.accio/

# fastlane
#
# It is recommended to not store the screenshots in the git repo. Instead, use fastlane to re-generate the
# screenshots whenever they are needed.
# It is recommended to not store the screenshots in the git repo.
# Instead, use fastlane to re-generate the screenshots whenever they are needed.
# For more information about the recommended setup visit:
# https://github.com/fastlane/fastlane/blob/master/fastlane/docs/Gitignore.md
# https://docs.fastlane.tools/best-practices/source-control/#source-control

fastlane/report.xml
fastlane/Preview.html
fastlane/screenshots
fastlane/screenshots/**/*.png
fastlane/test_output

# Code Injection
# After new code Injection tools there's a generated folder /iOSInjectionProject
# https://github.com/johnno1962/injectionforxcode

### Xcode ###
# Xcode
#
# gitignore contributors: remember to update Global/Xcode.gitignore, Objective-C.gitignore & Swift.gitignore

## Build generated
build/
DerivedData/

## Various settings
*.pbxuser
!default.pbxuser
*.mode1v3
!default.mode1v3
*.mode2v3
!default.mode2v3
*.perspectivev3
!default.perspectivev3
xcuserdata/

## Other
*.moved-aside
*.xccheckout
*.xcscmblueprint
iOSInjectionProject/


### Carthage ###
# Carthage - A simple, decentralized dependency manager for Cocoa
Carthage/Checkouts/
Carthage/Build/

.DS_Store
Brewfile.lock.json
# End of https://www.toptal.com/developers/gitignore/api/swift
11 changes: 0 additions & 11 deletions .overcommit.yml

This file was deleted.

3 changes: 0 additions & 3 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ opt_in_rules:
- overridden_super_call
- yoda_condition
- modifier_order
- anyobject_protocol
#- explicit_acl
- cyclomatic_complexity
#style
Expand Down Expand Up @@ -90,7 +89,6 @@ type_name:
- my
- BO
- bo
severity: error
identifier_name:
min_length: 3
max_length: 45
Expand All @@ -110,7 +108,6 @@ identifier_name:
- GlobalAPIKey
- bo
- BO
severity: error
attributes:
always_on_line_above:
- "@discardableResult"
Expand Down
Loading