Skip to content

Add public function to map a success task with another task publisher #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 30, 2024

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Jul 29, 2024

PR's key points

Add an operator to map a successful task into another task publisher by passing the success value in order to use the given value to do a new subscription (For example: to fetch a keyed task by his key)

How to review this PR?

Test green? go br!
We can discuss these change on a meeting :)

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 98.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (31907ca) to head (34f38d7).

Files Patch % Lines
Tests/PublishersTests+MapToLatestTask.swift 94.54% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   93.80%   93.99%   +0.18%     
==========================================
  Files          40       45       +5     
  Lines        2180     2397     +217     
==========================================
+ Hits         2045     2253     +208     
- Misses        135      144       +9     
Flag Coverage Δ
ios 93.99% <98.18%> (+0.32%) ⬆️
mac 93.99% <98.18%> (+0.18%) ⬆️
tv 93.99% <98.18%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThorBot
Copy link

ThorBot commented Jul 30, 2024

1 Warning
⚠️ Big PR, try to keep changes smaller if you can 😜
6 Messages
📖 Mini-iOSTests: Executed 67 tests, with 0 failures (0 expected) in 11.291 (11.313) seconds
📖 Mini-macOSTests: Executed 67 tests, with 0 failures (0 expected) in 11.251 (11.274) seconds
📖 Mini-tvOSTests: Executed 67 tests, with 0 failures (0 expected) in 11.284 (11.3) seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.013 seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.005 seconds
📖 ⌛️ [output] Slowest test: test_check_expiration_for_custom took 4.011 seconds

SwiftLint found issues

Warnings

File Line Reason
Dispatcher.swift 75 Returning Void in a function declaration is redundant (redundant_void_return)
None.swift 4 This default initializer would be synthesized automatically - you do not need to define it (unneeded_synthesized_initializer)
Publishers.CombineMiniTasksTuple3.swift 81 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple3.swift 91 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple4.swift 86 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple4.swift 97 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple2.swift 76 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
Publishers.CombineMiniTasksTuple2.swift 85 Opening braces should be preceded by a single space and on the same line as the declaration (opening_brace)
DispatcherTests.swift 12 Returning Void in a function declaration is redundant (redundant_void_return)
DispatcherTests.swift 13 Returning Void in a function declaration is redundant (redundant_void_return)
TestInterceptor.swift 26 Returning Void in a function declaration is redundant (redundant_void_return)

Generated by 🚫 Danger

@sebastianvarela sebastianvarela changed the title Add public function to flatter a success task with the received value Add public function to map a success task with another task publisher Jul 30, 2024
@sebastianvarela sebastianvarela merged commit bcdc779 into master Jul 30, 2024
8 checks passed
@sebastianvarela sebastianvarela deleted the task/flatmap_identifiable_tasks branch July 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants