-
Notifications
You must be signed in to change notification settings - Fork 0
Improve protocols naming, usability and fix minor bugs #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 89.76% 93.67% +3.91%
==========================================
Files 38 38
Lines 2090 2009 -81
==========================================
+ Hits 1876 1882 +6
+ Misses 214 127 -87
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Generated by 🚫 Danger |
PR's key points
.dispatch
helper to the task. (this fixisRecentlySucceed
use onKeyedCompletableTask
ServiceType
toService
TaskType
toTaskable
(This protocol is for type-erasure, not used directly)StoreType
(We use Store always directly)StateType
toState
and removeisEqual
function in order to useEquatable
(more swiftly)isEqual
fromAction
protocol, not used really.Middleware
Not usedService
intoInterceptor
(we need Chain? :S)How to review this PR?