Skip to content

Improve protocols naming, usability and fix minor bugs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 17, 2023

Conversation

sebastianvarela
Copy link
Collaborator

@sebastianvarela sebastianvarela commented Apr 13, 2023

PR's key points

  • First of all, fix publisher extension and pass expiration from .dispatch helper to the task. (this fix isRecentlySucceed use on KeyedCompletableTask
  • Rename ServiceType to Service
  • Rename TaskType to Taskable (This protocol is for type-erasure, not used directly)
  • Remove StoreType (We use Store always directly)
  • Rename StateType to State and remove isEqual function in order to use Equatable (more swiftly)
  • Remove isEqual from Action protocol, not used really.
  • Remove Middleware Not used
  • Rename Service into Interceptor (we need Chain? :S)

How to review this PR?

  • Check test and commit progression, we can talk these points.

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +3.91 🎉

Comparison is base (2c734d2) 89.76% compared to head (b8dd169) 93.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   89.76%   93.67%   +3.91%     
==========================================
  Files          38       38              
  Lines        2090     2009      -81     
==========================================
+ Hits         1876     1882       +6     
+ Misses        214      127      -87     
Flag Coverage Δ
ios 93.52% <100.00%> (+3.76%) ⬆️
mac 93.67% <100.00%> (+3.91%) ⬆️
tv 93.52% <100.00%> (+3.76%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/Actions/Action.swift 100.00% <ø> (ø)
Sources/Chain.swift 100.00% <ø> (ø)
Sources/Task/TaskExpiration.swift 86.66% <ø> (ø)
Tests/Helpers/TestActions.swift 100.00% <ø> (+60.00%) ⬆️
Tests/Helpers/TestState.swift 100.00% <ø> (ø)
Tests/Helpers/TestStoreController.swift 75.00% <ø> (ø)
Sources/Dispatcher.swift 90.97% <100.00%> (+12.26%) ⬆️
...shers/PublisherExtensions+CompletableActions.swift 100.00% <100.00%> (ø)
.../Publishers/Publishers.CombineMiniTasksArray.swift 97.50% <100.00%> (ø)
...Publishers/Publishers.CombineMiniTasksTuple2.swift 98.03% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ThorBot
Copy link

ThorBot commented Apr 13, 2023

1 Warning
⚠️ Big PR, try to keep changes smaller if you can 😜
2 Messages
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.011 seconds
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.006 seconds

Generated by 🚫 Danger

@sebastianvarela sebastianvarela changed the title TaskType -> Taskable Improve protocols naming, usability and fix minor bugs Apr 16, 2023
@sebastianvarela sebastianvarela merged commit 57dbf1e into master Apr 17, 2023
@sebastianvarela sebastianvarela deleted the task/naming branch April 17, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants