Skip to content

Simplify naming for task helpers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 12, 2023
Merged

Simplify naming for task helpers #14

merged 4 commits into from
Apr 12, 2023

Conversation

sebastianvarela
Copy link
Collaborator

PR's key points

  • Renamed:
    • .requestIdle to .idle
    • .requestRunning to .running
    • .requestFailure to .failure
    • .requestSuccess to .sucess
  • Removed obsolete code

How to review this PR?

Check tests

@ThorBot
Copy link

ThorBot commented Apr 12, 2023

5 Warnings
⚠️ Sources/Task/Task.swift#L137: 'init(status:started:expiration:tag:progress:)' is deprecated: Use static methods instead .idle(), .running(), .success() or .failure()
⚠️ Sources/Task/Task.swift#L146: 'init(status:started:expiration:tag:progress:)' is deprecated: Use static methods instead .idle(), .running(), .success() or .failure()
⚠️ Sources/Task/Task.swift#L156: 'init(status:started:expiration:tag:progress:)' is deprecated: Use static methods instead .idle(), .running(), .success() or .failure()
⚠️ Sources/Task/Task.swift#L167: 'init(status:started:expiration:tag:progress:)' is deprecated: Use static methods instead .idle(), .running(), .success() or .failure()
⚠️ Sources/Task/Task.swift#L200: 'init(status:started:expiration:tag:progress:)' is deprecated: Use static methods instead .idle(), .running(), .success() or .failure()
3 Messages
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.005 seconds
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.007 seconds
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.006 seconds

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 91.00% and project coverage change: +0.29 🎉

Comparison is base (7a20b10) 89.46% compared to head (7caa13c) 89.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   89.46%   89.76%   +0.29%     
==========================================
  Files          38       38              
  Lines        2078     2090      +12     
==========================================
+ Hits         1859     1876      +17     
+ Misses        219      214       -5     
Flag Coverage Δ
ios 89.61% <91.00%> (+0.30%) ⬆️
mac 89.76% <91.00%> (+0.29%) ⬆️
tv 89.61% <91.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Sources/Dispatcher.swift 78.70% <ø> (+7.77%) ⬆️
Sources/Extensions/DictionaryExtensions.swift 100.00% <ø> (+21.42%) ⬆️
Tests/Helpers/TestState.swift 100.00% <ø> (ø)
...Publishers/Publishers.CombineMiniTasksTuple3.swift 64.81% <50.00%> (ø)
...Publishers/Publishers.CombineMiniTasksTuple4.swift 94.73% <75.00%> (ø)
Sources/Task/Task.swift 78.46% <83.78%> (-8.28%) ⬇️
...shers/PublisherExtensions+CompletableActions.swift 100.00% <100.00%> (ø)
.../Publishers/PublisherExtensions+EmptyActions.swift 100.00% <100.00%> (ø)
.../Publishers/Publishers.CombineMiniTasksArray.swift 97.50% <100.00%> (ø)
...Publishers/Publishers.CombineMiniTasksTuple2.swift 98.03% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

adrianrl
adrianrl previously approved these changes Apr 12, 2023
@sebastianvarela sebastianvarela merged commit 7cec951 into master Apr 12, 2023
@sebastianvarela sebastianvarela deleted the task/naming branch April 12, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants