Skip to content

Add extension to dispatch attributed actions from publishers #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 27, 2023

Conversation

sebastianvarela
Copy link
Collaborator

PR's key points

Add .dispatch extension to dispatch from a publisher directly to AttributedEmptyAction & AttributedCompletableAction

@ThorBot
Copy link

ThorBot commented Mar 24, 2023

1 Message
📖 ⌛️ [output] Slowest test: test_success_task_with_expiration_setted took 3.011 seconds

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@e42df92). Click here to learn what that means.
Patch coverage: 87.09% of modified lines in pull request are covered.

❗ Current head a297b79 differs from pull request most recent head 66b15ed. Consider uploading reports for the commit 66b15ed to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #11   +/-   ##
=========================================
  Coverage          ?   80.41%           
=========================================
  Files             ?       29           
  Lines             ?     1062           
  Branches          ?        0           
=========================================
  Hits              ?      854           
  Misses            ?      208           
  Partials          ?        0           
Flag Coverage Δ
ios 80.13% <87.09%> (?)
mac 80.41% <87.09%> (?)
tv 80.41% <87.09%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Tests/Helpers/TestActions.swift 40.00% <40.00%> (ø)
...shers/PublisherExtensions+CompletableActions.swift 100.00% <100.00%> (ø)
.../Publishers/PublisherExtensions+EmptyActions.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sebastianvarela sebastianvarela merged commit 45ba59a into master Mar 27, 2023
@sebastianvarela sebastianvarela deleted the dispatch_attributed_actions branch March 27, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants