Bugfix/contributions pagination #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pps-android-commons into maskaravivek-lazyContributions
* Use PageId as primary Key * show progress in CLF only whenn contributions are empty (graceful pagination) * Migration 1_2
| @Override | ||
| public void migrate(SupportSQLiteDatabase database) { | ||
| database.execSQL("DROP TABLE `contribution`"); | ||
| database.execSQL("CREATE TABLE IF NOT EXISTS `contribution` (" |
There was a problem hiding this comment.
@ashishkumar468 Do we need to specify all the columns manually? Does room not pick the columns based on the model class.
PS: I am not very familiar with how room works.
There was a problem hiding this comment.
Yes it does, but for migration, we have to let it know exactly what it's supposed to do, as you can see we only have the DB as the parameter to work upon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BugFixes Lazy Load Contributions
* Use PageId as primary Key
* show progress in CLF only when contributions are empty (graceful pagination)
* Migration 1_2