Skip to content

Update Picklist for SLDS2 #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: support-slds-2
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
214c35d
(Picklist): update markups to combobox pattern
msmx-mnakagawa Jun 13, 2025
4dd62f9
(Picklist): update classnames for dropdown sizing
msmx-mnakagawa Jun 4, 2025
18274d8
(Picklist): improve a11y for disabled state
msmx-mnakagawa Jun 4, 2025
c89d412
Merge branch 'support-slds-2' into support-slds-2-picklist
msmx-mnakagawa Jun 17, 2025
5718342
(Picklist): add a `scrollIntoView()` behavoir
msmx-mnakagawa Jun 17, 2025
a4f0c44
(Picklist): refactor to use `optionIdPrefix`
msmx-mnakagawa Jun 17, 2025
610776d
(Picklist): make `getPrevValue()` and `getNextValue()` not wrap around
msmx-mnakagawa Jun 18, 2025
52ff2a4
(Picklist): add Tab / Shift + Tab support
msmx-mnakagawa Jun 18, 2025
356ca4a
Merge branch 'support-slds-2' into support-slds-2-picklist
msmx-mnakagawa Jun 19, 2025
88f3f0e
Merge branch 'support-slds-2' into support-slds-2-picklist
msmx-mnakagawa Jun 19, 2025
1da593e
use `DropdownMenu` to delegate keyboard handlers
msmx-mnakagawa Jun 19, 2025
ecf43a5
restore the existing implementation as much as possible
msmx-mnakagawa Jun 19, 2025
13fe21d
(Picklist): remove `aria-labelledby` for concistency
msmx-mnakagawa Jun 19, 2025
df4398d
Revert "restore the existing implementation as much as possible"
msmx-mnakagawa Jun 19, 2025
dfe1d79
Revert "use `DropdownMenu` to delegate keyboard handlers"
msmx-mnakagawa Jun 19, 2025
e1721e4
(Picklit): simplify scrolling logic
msmx-mnakagawa Jun 19, 2025
de94337
(Picklist): enable to open a picklist with `Tab` key
msmx-mnakagawa Jun 19, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading