Skip to content

Update Badge for SLDS2 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Update Badge for SLDS2 #458

merged 4 commits into from
Jun 5, 2025

Conversation

msmx-mnakagawa
Copy link
Collaborator

@msmx-mnakagawa msmx-mnakagawa commented May 23, 2025

What I did

  • update a classname
  • remove unsupported types
  • add newly supported types

What I would like to confirm

Whether we need to add new types (lightest, success warning, and error).

Reference

https://v1.lightningdesignsystem.com/components/badges/

@msmx-mnakagawa msmx-mnakagawa self-assigned this May 23, 2025
Copy link

reg-suit bot commented May 23, 2025

reg-suit detected visual differences.

Check this report, and review them.

🔴
⚪⚪⚪⚪

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@msmx-mnakagawa msmx-mnakagawa force-pushed the support-slds-2-badge branch from 14e4781 to b789f2d Compare May 23, 2025 05:44
@msmx-mnakagawa msmx-mnakagawa changed the base branch from update-slds-to-the-latest to support-slds-2 May 23, 2025 05:44
@msmx-mnakagawa msmx-mnakagawa requested a review from stomita May 23, 2025 07:06
@msmx-mnakagawa msmx-mnakagawa marked this pull request as ready for review May 23, 2025 07:06
@msmx-mnakagawa msmx-mnakagawa marked this pull request as draft May 28, 2025 22:54
@msmx-mnakagawa msmx-mnakagawa marked this pull request as ready for review May 28, 2025 22:55
@stomita stomita merged commit 255088c into support-slds-2 Jun 5, 2025
2 checks passed
@msmx-mnakagawa msmx-mnakagawa mentioned this pull request Jun 5, 2025
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants