Skip to content

#154 (https://github.com/masesgroup/KNet/issues/154#issuecomment-1328076661): first basic implementation#155

Merged
masesdevelopers merged 3 commits into
masesgroup:masterfrom
masesdevelopers:154-add-options-to-enabledisable-jmx-1
Nov 27, 2022
Merged

#154 (https://github.com/masesgroup/KNet/issues/154#issuecomment-1328076661): first basic implementation#155
masesdevelopers merged 3 commits into
masesgroup:masterfrom
masesdevelopers:154-add-options-to-enabledisable-jmx-1

Conversation

@masesdevelopers
Copy link
Copy Markdown
Contributor

@masesdevelopers masesdevelopers commented Nov 26, 2022 •
edited
Loading

Description

First implementation of issue #154: see #154 (comment)

Related Issue

#154
Fix #110

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@masesdevelopers masesdevelopers added enhancement New feature or request KNet KNet related issue labels Nov 26, 2022
@masesdevelopers masesdevelopers self-assigned this Nov 26, 2022
mariomastrodicasa
mariomastrodicasa requested changes Nov 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mariomastrodicasa mariomastrodicasa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masesdevelopers documentation must be changed accordingly and KNetPS seems not manage the new switches.

Comment thread src/net/KNet/KNetCore.cs Outdated
Comment thread src/net/KNet/KNetCore.cs Outdated
Comment thread src/net/KNet/KNetCore.cs Outdated
@masesdevelopers masesdevelopers added KNetPS KNetPS related issue documentation Improvements or additions to documentation labels Nov 26, 2022
@masesdevelopers masesdevelopers merged commit eb9cd9b into masesgroup:master Nov 27, 2022
@masesdevelopers masesdevelopers deleted the 154-add-options-to-enabledisable-jmx-1 branch November 27, 2022 01:48
@masesdevelopers masesdevelopers linked an issue Nov 27, 2022 that may be closed by this pull request
Add options to Enable/Disable JMX #154
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariomastrodicasa mariomastrodicasa mariomastrodicasa approved these changes

Assignees

@masesdevelopers masesdevelopers

Labels

documentation Improvements or additions to documentation enhancement New feature or request KNet KNet related issue KNetPS KNetPS related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add options to Enable/Disable JMX Website is not aligned to the last repository state

2 participants

@masesdevelopers @mariomastrodicasa