Return false for non-whitespace Unicode code points - #305
Merged
marzer merged 1 commit intoJul 21, 2026
Merged
Conversation
The generated horizontal-whitespace lookup can reach its default branch for code points that are not whitespace. Returning false matches the explicit cases and allows the parser to report the input error normally. The regression covers both reported input sequences through the public parser. Constraint: toml.hpp must be regenerated from changes under include/ Rejected: Preserve TOML_UNREACHABLE in the default branch | the branch is reachable for non-whitespace code points Confidence: high Scope-risk: narrow Directive: Regenerate toml.hpp whenever the source headers change Tested: GCC 15 static Meson build; 55 Catch2 cases / 47782 assertions with LC_ALL=C; source and single-header public API regression Not-tested: Non-C Windows locale variants are unavailable locally; official single-header CI wrapper requires a missing py Python 3 launcher
Owner
|
Nice, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295.
The horizontal-whitespace lookup can reach its default case for code points that are not whitespace. Return false there, matching the existing explicit cases, so parsing reports an input error normally.