-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
Modify debian to package qt6.
deepin pr auto review代码审查意见:
总体来说,这些更改看起来是合理的,但是需要确保所有相关的代码和依赖项都已经更新以支持新的版本号。此外,还需要进行全面的测试以确保这些更改不会引入任何问题。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @18202781743 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider using a variable instead of hardcoding the Qt version in multiple places.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's Guide by SourceryThis pull request updates the Debian packaging to use Qt6. It modifies the CMakeLists.txt to set the DTK and Qt versions to 6, and updates the debian/control and debian/rules files to reflect the Qt6 dependencies and build process. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Modify debian to package qt6.
Summary by Sourcery
Switches the Debian packaging to use Qt6 instead of Qt5.
Chores: