Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Conversation

@18202781743
Copy link
Contributor

@18202781743 18202781743 commented Mar 25, 2025

Modify debian to package qt6.

Summary by Sourcery

Switches the Debian packaging to use Qt6 instead of Qt5.

Chores:

  • Updates the DTK_VERSION to 6 in CMakeLists.txt.
  • Updates the Debian control file to reflect the change to Qt6.

Modify debian to package qt6.
@deepin-ci-robot
Copy link

deepin pr auto review

代码审查意见:

  1. CMakeLists.txt 文件中的版本号更新

    • 修改了 DTK_VERSION 从 "5" 到 "6",这是一个合理的版本更新。但是,需要确保所有相关的代码和依赖项都已经更新以支持新的版本号。如果有其他地方硬编码了 "5",也需要进行相应的更新。
  2. debian/control 文件中的依赖项更新

    • libdtkcore-dev 更新为 libdtk6core-devlibdtkcore5-bin 更新为 libdtk6core-binqtbase5-dev 更新为 qt6-base-devlibpolkit-qt5-1-dev 更新为 libpolkit-qt6-1-dev。这些更新是必要的,因为版本号从 "5" 更新到 "6"。需要确保这些新的库版本在系统中可用,并且与项目的其他部分兼容。
  3. debian/rules 文件中的配置命令

    • 添加了 override_dh_auto_configure 目标,并使用 -DDTK_VERSION=6 参数。这是一个好的做法,因为它允许在构建过程中动态设置版本号。但是,需要确保在构建过程中没有其他地方硬编码了 "5" 的版本号。

总体来说,这些更改看起来是合理的,但是需要确保所有相关的代码和依赖项都已经更新以支持新的版本号。此外,还需要进行全面的测试以确保这些更改不会引入任何问题。

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @18202781743 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider using a variable instead of hardcoding the Qt version in multiple places.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@sourcery-ai
Copy link

sourcery-ai bot commented Mar 25, 2025

Reviewer's Guide by Sourcery

This pull request updates the Debian packaging to use Qt6. It modifies the CMakeLists.txt to set the DTK and Qt versions to 6, and updates the debian/control and debian/rules files to reflect the Qt6 dependencies and build process.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the DTK version to 6 and QT_VERSION_MAJOR to 6.
  • Set DTK_VERSION to "6".
  • Set QT_VERSION_MAJOR to "6".
CMakeLists.txt
Modified debian packaging to use Qt6.
  • Updated dependencies in debian/control to reflect Qt6.
  • Modified debian/rules to build with Qt6.
debian/control
debian/rules

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 2722b5f into martyr-deepin:master Mar 25, 2025
15 of 16 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants