packaging: Fix %files in spec #240
Draft
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/packit build |
|
@lachmanfrantisek @lbarcziova Can you please help me with packit being AWOL here? https://dashboard.packit.dev/jobs/srpm doesn't have any trace of it. I just rebased and landed #153 and that didn't have it either. Thanks! |
|
@lachmanfrantisek @lbarcziova whatever you did, thank you! 🤗 |
|
The module name seems to be dbusmock, not python_dbusmock. You also need to package the dist-info folder as well. The easiest way to do this is to use %pyproject_save_files: %install
%pyproject_install
%pyproject_save_files -l dbusmock
...
%files -n python3-dbusmock -f %{pyproject_files} |
|
@hroncok Right, thanks -- I sent this in a hurry yesterday. Now I devoted some actual time to it. Fixed, thanks for the save_files tip! |
That was missing from commit c98793c.
There is a Python `packaging` module as well, and ruff's "I001 Import block is un-sorted or un-formatted" rule mistook the packaging/ directory as local module.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include Also thanks to Miro Hrončok!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include