This repository was archived by the owner on Jul 16, 2020. It is now read-only.
Fix locale association #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 23, 2020 11:08
When using multiple locales with e.g. a_locale.json files *and* folders with php files a_locale/errors.php then the translations were mixed in the wrong files because of a wrong "lastLocale". The locale will now be determined by the given file path. That results to the correct association.
Fix locale association
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple locales with e.g. a_locale.json files and folders with php files a_locale/errors.php then the translations were mixed in the wrong files because of a wrong "lastLocale" variable. The locale will now be determined by the given file path. That results to the correct association.
In my example translations from de and en had been merged to fr.js. With this patch it correct.
E.g. with:
resources/lang/{de|fr|en|pl|es}.json AND
resources/lang/{de|fr|en|pl|es}/errors.php
resources/lang/{de|fr|en|pl|es}/fields.php etc.
and Command:
php artisan vue-i18n:generate --multi-locales