Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions #2392

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Fix permissions #2392

merged 1 commit into from
Feb 8, 2025

Conversation

martincostello
Copy link
Owner

  • Fix permissions for PR comments.
  • Remove redundant permissions.

- Fix permissions for PR comments.
- Remove redundant permissions.
@martincostello martincostello added bug github_actions Pull requests that update GitHub Actions code labels Feb 8, 2025
@Copilot Copilot bot review requested due to automatic review settings February 8, 2025 15:47
@martincostello martincostello enabled auto-merge (rebase) February 8, 2025 15:47

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:5001

Device URL
mobile https://localhost:5001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (36be7d7) to head (bd4c65f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files          33       33           
  Lines         590      590           
  Branches       69       69           
=======================================
  Hits          510      510           
  Misses         37       37           
  Partials       43       43           
Flag Coverage Δ
linux 86.44% <ø> (ø)
macos 86.44% <ø> (ø)
windows 86.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit b23e7fa into main Feb 8, 2025
13 checks passed
@martincostello martincostello deleted the fix-permissions-2 branch February 8, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants