Support custom IServer with LambdaTestServer #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support using a custom IServer with LambdaTestServer. This enables, for example, running the test server on a real HTTP port.
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 99.26% 99.29% +0.03%
==========================================
Files 8 8
Lines 271 283 +12
==========================================
+ Hits 269 281 +12
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Add a unit test for if CreateServer() returns null.
Reduce copy-paste by moving the code to get the base address into a private method. Add unit test for if the server has no addresses.
Add a sample project and unit test for running a Minimal API as a Lambda function with API Gateway.
Add content about the custom Lambda IServer. Update some out-of-date references/links.
Simplify the test by just using Task.Run().
Do not run the two LambdaTestServer test classes in parallel with each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support using a custom
IServerwithLambdaTestServer.This enables, for example, running the test server on a real HTTP port.
TODO