Skip to content

Commit

Permalink
Fix rubocop and kitchen complaints (see full msg)
Browse files Browse the repository at this point in the history
.rubocop.yml - AllCops/Excludes was renamed to AllCops/Exclude

Warning: Deprecated pattern style 'vendor/**' in .rubocop.yml. Change to 'vendor/**/*'.

metadata.rb:1:5: C: Put one space between the method name and the first argument.
name             'xml'
    ^^^^^^^^^^^^^
metadata.rb:2:11: C: Put one space between the method name and the first argument.
maintainer       'Opscode, Inc.'
          ^^^^^^^
metadata.rb:4:8: C: Put one space between the method name and the first argument.
license          'Apache 2.0'
       ^^^^^^^^^^
metadata.rb:5:12: C: Put one space between the method name and the first argument.
description      'Installs xml'
           ^^^^^^
metadata.rb:7:8: C: Put one space between the method name and the first argument.
version          '1.2.5'
       ^^^^^^^^^^
attributes/default.rb:24:32: C: %w-literals should be delimited by ( and )
  default['xml']['packages'] = %w[libxml2-devel libxslt-devel]
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
attributes/default.rb:26:32: C: %w-literals should be delimited by ( and )
  default['xml']['packages'] = %w[libxml2-dev libxslt-dev]
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
attributes/default.rb:28:32: C: %w-literals should be delimited by ( and )
  default['xml']['packages'] = %w[libxml2 libxslt]
                               ^^^^^^^^^^^^^^^^^^^
  • Loading branch information
martinb3 committed May 14, 2014
1 parent 3ea5015 commit 16770c1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
9 changes: 7 additions & 2 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
AllCops:
Excludes:
- vendor/**
Exclude:
- vendor/**/*

AlignParameters:
Enabled: false
Expand All @@ -12,3 +12,8 @@ LineLength:
Enabled: false
MethodLength:
Max: 30
#
# we like our neatly-aligned code too much
#
SingleSpaceBeforeFirstArg:
Enabled: false
1 change: 1 addition & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ gem 'rubocop', '~> 0.12'
group :integration do
gem 'test-kitchen', '~> 1.0.0.beta'
gem 'kitchen-vagrant', '~> 0.11'
gem 'vagrant-wrapper', '~> 1.2'
end
6 changes: 3 additions & 3 deletions attributes/default.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@

case node['platform_family']
when 'rhel', 'fedora', 'suse'
default['xml']['packages'] = %w[libxml2-devel libxslt-devel]
default['xml']['packages'] = %w(libxml2-devel libxslt-devel)
when 'ubuntu', 'debian'
default['xml']['packages'] = %w[libxml2-dev libxslt-dev]
default['xml']['packages'] = %w(libxml2-dev libxslt-dev)
when 'freebsd', 'arch'
default['xml']['packages'] = %w[libxml2 libxslt]
default['xml']['packages'] = %w(libxml2 libxslt)
end

default['xml']['nokogiri']['use_system_libraries'] = true

0 comments on commit 16770c1

Please sign in to comment.