Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update from latest master, fix some typos #1

Merged
merged 32 commits into from
Jun 10, 2015

Conversation

gbirchmeier
Copy link

Hi @martinadams,

Great code, great tests. This PR updates your PR with the following:

  • (bb191ce) updates it to the latest master (resolving merge conflicts)
  • (5d17cc3) fixes some doc-comment typos and improves (I hope) the wording of some sentences and error messages
  • (a8153fe) update NEXT_VERSION.md

Please look it over. When/if you accept it into your PR, then I'll merge your PR into main.

-Grant

martinadams and others added 30 commits November 16, 2014 15:47
Add the missing calls to refresh the MessageStore if RefreshOnLogon config option
has been specfiied.
…bound messages.

Add an IApplicationExt interface that extends IApplication and facilitates early
intercept of inbound messages on the part of the Application.

This is a bit similar to the late outbound intercept afforded by ToApp/ToAdmin,
and permits alteration of field values prior to their being validated by the engine.
The difference is that, with the new interface, only one callback is provided for
both App and Admin messages.

Usage of the existing IApplication interface is unaffected.
Allow new sessions to be added and existing sessions to be
deleted while the engine is running.
Allows initiator and acceptor session config to be added to, and
removed from, a running engine. In the case of removal, caller
can specify whether a fully logged on connection belonging
to the relevant session should be terminated, or whether the
attempt to remove should fail under this condition.
This reverts commit 446d42e, reversing
changes made to 469392f.

Unintended merge
Add new Application Callback (non-breaking) for early intercept of inbou...
(connamara#80) acceptor shouldn't include 141=Y in logon responses
get rid of unnecessary and inexplicable gitignore files
don't include unneeded sessions in AT config files
Revert "these should have been committed long ago" - that was a bad move
…nto 314

Conflicts:
	QuickFIXn/IApplicationExt.cs
	UnitTests/SessionTest.cs
martinadams added a commit that referenced this pull request Jun 10, 2015
update from latest master, fix some typos
@martinadams martinadams merged commit 259441c into martinadams:master Jun 10, 2015
@martinadams
Copy link
Owner

Merged: thanks for the fixes - I obviously need a spell-checker!

Martin

From: Grant Birchmeier [mailto:notifications@github.com]
Sent: 10 June 2015 22:11
To: martinadams/quickfixn
Cc: martinadams
Subject: [quickfixn] update from latest master, fix some typos (#1)

Hi @martinadams https://github.com/martinadams ,

Great code, great tests. This PR updates your PR with the following:

  • ( bb191ce bb191ce) updates it to the latest master (resolving merge conflicts)
  • ( 5d17cc3 5d17cc3) fixes some doc-comment typos and improves (I hope) the wording of some sentences and error messages
  • ( a8153fe a8153fe) update NEXT_VERSION.md

Please look it over. When/if you accept it into your PR, then I'll merge your PR into main.

-Grant


You can view, comment on, or merge this pull request online at:

#1

Commit Summary

File Changes

Patch Links:


Reply to this email directly or view it on GitHub #1 . https://github.com/notifications/beacon/AHjGLC9WFdsENydz2PSSYVjcn3iixsl6ks5oSJ9igaJpZM4E-5hn.gif

@gbirchmeier gbirchmeier deleted the 314 branch June 12, 2015 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants