Update actions #38
Update actions #38
Conversation
| continue-on-error: ${{ matrix.php == '8.0' }} | ||
| name: PHP ${{ matrix.php }}, PHPUnit ${{ matrix.phpunit }} | ||
|
|
||
| name: PHP ${{ matrix.php }} |
There was a problem hiding this comment.
Since this library not just uses PHPUnit as dependency, but is in itself also intended as an addon for PHPUnit, I'd like to keep testing against multiple versions of PHPUnit (at least those that are supported by this lib, which tend to correlate with the officially supported versions).
There was a problem hiding this comment.
The idea is, to let composer decide, which PHPUnit version to use, depending on the current PHP version. It should cover most versions, without explicitly declaring them.
There was a problem hiding this comment.
My assumption was that most users will have a dependency to phpunit/phpunit declared directly in the require-dev section of their composer.json, and will then require-dev any assertion libraries (like this one) on top/in addition to their existing PHPUnit requirements.
| - '*' | ||
| - '!v1' | ||
| - '!v2' |
There was a problem hiding this comment.
I'd prefer keeping the tags configuration, here.
| - '!v2' | |
| - '!v2' | |
| tags: | |
| - '*' |
There was a problem hiding this comment.
That doesn't make much sense Imho.
There was a problem hiding this comment.
There's just absolutely no need to perform another test upon tag creation. Creating a tag requires a push or a merged PR and in both cases, the tests have already been performed.
| paths: | ||
| - '**.php' | ||
| - 'composer.json' |
There was a problem hiding this comment.
That seems unnecessarily restrictive. I can already see a maintainer in a far-distant future (probably me) wonder why a pipeline didn't run after modifying the phpunit.xml, or adding a fixture JSON file, etc. I'm fine with non-code changes triggering an extra (potentially superflous) build for the sake of simplicity.
| paths: | |
| - '**.php' | |
| - 'composer.json' |
| paths: | ||
| - '**.php' | ||
| - 'composer.json' |
There was a problem hiding this comment.
Same as above.
| paths: | |
| - '**.php' | |
| - 'composer.json' |
n/t