Skip to content

Enhance XAUUSD bot #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2025
Merged

Enhance XAUUSD bot #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51f2655
Fix trailing stop handling
martcklm Jun 12, 2025
58a3548
Merge branch 'master' into x5xkuk-codex/create-gold-trading-algo-bot-…
martcklm Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 11 additions & 35 deletions Robots/XAUUSD Trend Strategy/XAUUSD Trend Strategy/GoldTrendStrategy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@
// profit of any kind. Use it at your own risk.
//
// -------------------------------------------------------------------------------------------------

using System;
using cAlgo.API;
using cAlgo.API.Indicators;
using cAlgo.API.Internals;
using cAlgo.API;
using cAlgo.API.Indicators;

namespace cAlgo.Robots
{
Expand All @@ -24,7 +23,7 @@ public class GoldTrendStrategy : Robot
private RelativeStrengthIndex _rsi;
private Supertrend _supertrend;
private MacdCrossOver _macd;

[Parameter("Fast MA Source", Group = "Fast MA")]
public DataSeries FastMaSource { get; set; }

Expand Down Expand Up @@ -76,9 +75,6 @@ public class GoldTrendStrategy : Robot
[Parameter("Trailing Stop (Pips)", DefaultValue = 50, Group = "Trade", MinValue = 0)]
public double TrailingStopInPips { get; set; }

[Parameter("Volume (Lots)", DefaultValue = 0.01, Group = "Trade")]
public double VolumeInLots { get; set; }

[Parameter("Stop Loss (Pips)", DefaultValue = 100, Group = "Trade", MinValue = 1)]
public double StopLossInPips { get; set; }

Expand All @@ -95,15 +91,12 @@ protected override void OnStart()

if (!UseDynamicVolume)
_volumeInUnits = Symbol.QuantityToVolumeInUnits(VolumeInLots);

_fastMa = Indicators.SimpleMovingAverage(FastMaSource, FastMaPeriod);
_slowMa = Indicators.SimpleMovingAverage(SlowMaSource, SlowMaPeriod);
_rsi = Indicators.RelativeStrengthIndex(Bars.ClosePrices, RsiPeriod);
_supertrend = Indicators.Supertrend(SupertrendPeriods, SupertrendMultiplier);
_macd = Indicators.MacdCrossOver(Bars.ClosePrices, MacdLongCycle, MacdShortCycle, MacdSignalPeriods);
_volumeInUnits = Symbol.QuantityToVolumeInUnits(VolumeInLots);
_fastMa = Indicators.SimpleMovingAverage(FastMaSource, FastMaPeriod);
_slowMa = Indicators.SimpleMovingAverage(SlowMaSource, SlowMaPeriod);
_rsi = Indicators.RelativeStrengthIndex(MarketSeries.Close, RsiPeriod);

_fastMa.Result.Line.Color = Color.Gold;
_slowMa.Result.Line.Color = Color.DarkOrange;
Expand Down Expand Up @@ -136,14 +129,14 @@ protected override void OnBarClosed()

protected override void OnTick()
{
if (TrailingStopInPips <= 0)
return;

foreach (var position in Positions.FindAll(Label))
{
double? newStopLoss;

if (position.TradeType == TradeType.Buy)
newStopLoss = Symbol.Bid - TrailingStopInPips * Symbol.PipSize;
else
newStopLoss = Symbol.Ask + TrailingStopInPips * Symbol.PipSize;
double? newStopLoss = position.TradeType == TradeType.Buy
? Symbol.Bid - TrailingStopInPips * Symbol.PipSize
: Symbol.Ask + TrailingStopInPips * Symbol.PipSize;

if (position.TradeType == TradeType.Buy && (position.StopLoss == null || newStopLoss > position.StopLoss))
ModifyPosition(position, newStopLoss, position.TakeProfit);
Expand All @@ -164,29 +157,12 @@ private double GetTradeVolume()
return Symbol.NormalizeVolumeInUnits(units, RoundingMode.ToNearest);
}

var inUptrend = _fastMa.Result.LastValue > _slowMa.Result.LastValue;
var inDowntrend = _fastMa.Result.LastValue < _slowMa.Result.LastValue;

if (inUptrend && _rsi.Result.LastValue < Oversold)
{
ClosePositions(TradeType.Sell);
ExecuteMarketOrder(TradeType.Buy, SymbolName, _volumeInUnits, Label, StopLossInPips, TakeProfitInPips);
}
else if (inDowntrend && _rsi.Result.LastValue > Overbought)
{
ClosePositions(TradeType.Buy);
ExecuteMarketOrder(TradeType.Sell, SymbolName, _volumeInUnits, Label, StopLossInPips, TakeProfitInPips);
}
}

private void ClosePositions(TradeType tradeType)
{
foreach (var position in Positions.FindAll(Label))
{
if (position.TradeType != tradeType)
continue;

ClosePosition(position);
if (position.TradeType == tradeType)
ClosePosition(position);
}
}
}
Expand Down