Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev requirements install #973

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

un4gt
Copy link
Contributor

@un4gt un4gt commented Sep 10, 2024

The command pip install -e '.[dev]' results in a syntax error on some systems due to single quotes.

In windows :

pip install -e '.[dev]'
ERROR: '.[dev]' is not a valid editable requirement. It should either be a path to a local project or a VCS URL (beginning with bzr+http, bzr+https, bzr+ssh, bzr+sftp, bzr+ftp, bzr+lp, bzr+file, git+http, git+https, git+ssh, git+git, git+file, hg+file, hg+http, hg+https, hg+ssh, hg+static-http, svn+ssh, svn+http, svn+https, svn+svn, svn+file).

By using double quotes (pip install -e ".[dev]"), the command runs successfully on all platforms, ensuring better cross-platform compatibility.

.gitignore Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
@lafrech
Copy link
Member

lafrech commented Sep 10, 2024

The CI failure is unrelated and seems to be due to changes in bottle 0.13.

@sirosen
Copy link
Collaborator

sirosen commented Sep 10, 2024

The CI failure is unrelated and seems to be due to changes in bottle 0.13.

I'll plan to look into that either today or tomorrow.

@lafrech
Copy link
Member

lafrech commented Sep 10, 2024

Thanks Stephen.

It seems related to how unicode errors are treated but I haven't gotten to the bottom of it and I gotta go.

I scrolled through bottle changelog and nothing stroke me as relevant to this issue.

@sloria sloria enabled auto-merge (squash) September 11, 2024 14:50
@sloria sloria merged commit 1be0cf4 into marshmallow-code:dev Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants