Improve type annotations for the pyramid and tornado parsers #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable 'disallow_untyped_defs=false' for this module - repair the resulting type errors (with liberal use of Any)
- Update 'mypy' to v1.10.0 in tox.ini - Add annotations to pyramid module, such that mypy overrides are no longer needed The mypy version bump is needed to match up with the pre-commit version, and handles `__wrapped__` correctly.
sloria
approved these changes
May 31, 2024
|
Thanks for taking care of this. CI errors on 3.8. Could it be a |
|
That's exactly what it is; I'll get that fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset takes a few steps towards getting rid of mypy type checking overrides, and therefore enforcing that there are annotations everywhere.
It targets the tornado and pyramid modules.
As a related change, this updates the mypy version pinned in tox.ini to the latest.