Document parsing lists in query strings; remove duck typing #407

sloria · 2019-07-24T02:45:55Z

close #406

sloria · 2019-07-24T02:46:31Z

src/webargs/core.py

@@ -65,7 +65,11 @@ class Meta(object):

 def is_multiple(field):
    """Return whether or not `field` handles repeated/multi-value arguments."""
-    return isinstance(field, ma.fields.List) and not hasattr(field, "delimiter")


We probably did this to avoid the circular import. Was a bad decision in retrospect.

sloria added 2 commits July 23, 2019 22:30

Add documentation for parsing lists in query strings

0e94b64

Use explicit type check instead of duck typing

cdfbc8b

See #406 (comment)

sloria commented Jul 24, 2019

View reviewed changes

sloria merged commit d5c5ac5 into dev Jul 24, 2019

sloria deleted the delimitedlist-improvements branch July 24, 2019 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Document parsing lists in query strings; remove duck typing #407

Document parsing lists in query strings; remove duck typing #407

sloria commented Jul 24, 2019

sloria Jul 24, 2019

Document parsing lists in query strings; remove duck typing #407

Document parsing lists in query strings; remove duck typing #407

Conversation

sloria commented Jul 24, 2019

sloria Jul 24, 2019

Choose a reason for hiding this comment