Fix Constant field with required=True raising ValueError#2910
Open
rstar327 wants to merge 1 commit intomarshmallow-code:devfrom
Open
Fix Constant field with required=True raising ValueError#2910rstar327 wants to merge 1 commit intomarshmallow-code:devfrom
rstar327 wants to merge 1 commit intomarshmallow-code:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2900
fields.Constantalways setsload_defaultto the constant value internally. Since #2894 added a check that rejectsload_defaulton required fields,Constant(constant, required=True)now raisesValueError.This PR fixes the issue by:
requiredfrom kwargs before callingsuper().__init__(), then setting it after_validate_missinginConstantto skip the required-field check, since the constant value is always available viaload_defaultAll 1133 tests pass.