Fix Constant(None) field rejecting null input #2895
Draft
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
Constantfield is initialized withNoneas the constant value, loading a payload containing null would incorrectly raise:Root Cause
The issue was in the initialization order:
Constant.__init__callssuper().__init__(**kwargs)Field.__init__computesallow_nonebased onload_default(line 213)load_defaultis stillmissing_(not passed in kwargs)allow_noneis computed asFalseConstant.__init__setself.load_default = constantallow_nonehas already been incorrectly setFix
Pass
load_defaultanddump_defaultto the parent constructor viakwargs.setdefault()so thatallow_noneis computed correctly when the constant isNone.Test Plan
Added test
test_constant_none_allows_null_inputthat verifies:{"sentinel": None}works without raising ValidationError{"sentinel": "anything"}also works (constant always wins)Fixes #2868