Various typing improvements to fields module #2723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sloria heads up that this is likely a major breaking change. This took us down today because it broke Airflow's APIs: apache/airflow#45442 Since this does schema validation, this effectively caused all of my Airflow API requests to suddenly start 400'ing on my next deploy (deploys re pip-install things when the container is rebuilt). I have business critical functions that depend on programatically launching DAGs. All of those broke suddenly. |
Member
|
The real change is in 4.0. 3.24 adds deprecation warnings. (The change did break my build, but AFAIU, this was due to an issue in marshmallow-sqlalchemy that is now fixed.) |
CheckmkCI
pushed a commit
to Checkmk/checkmk
that referenced
this pull request
Jan 24, 2025
In marshmallow 3.24.0, Field.parent is not a class attribute anymore, but an instance attribute, see marshmallow-code/marshmallow#2723. In any case, always calling super().__init__(...) and as the first statement of a constructor is a very good idea. Otherwise your class hierarchies involving the class in question can and *will* break sooner or later due to the way the MRO works. Change-Id: I414be7062822f984444d2508061e9c2885860d88
CheckmkCI
pushed a commit
to Checkmk/checkmk
that referenced
this pull request
Feb 12, 2025
We need to track the signature changes of Fields.Nested, see marshmallow-code/marshmallow#2723. CMK-21417 Change-Id: Idf723bc5360a46a9a1f68e78776dab895e5be247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.