This repository was archived by the owner on Jun 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 651
Deploy with auto build #156
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c61d5fd
Use Node buildpack‘s auto build
mars 840a72b
Remove NODE_ENV=development workaround since Node buildpack installs …
mars 23922e9
📚 link to Dev Center for Node.js build customization
mars f097a82
Switch to new Node auto build behavior ahead of release
mars 835e54a
Upgrade to "Node auto build" release version of inner buildpack
mars File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
https://github.com/heroku/heroku-buildpack-nodejs.git | ||
https://github.com/mars/create-react-app-inner-buildpack.git#v8.0.0 | ||
https://github.com/mars/create-react-app-inner-buildpack.git#v9.0.0 | ||
https://github.com/heroku/heroku-buildpack-static.git |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,6 +23,9 @@ CACHE_DIR=$2 | |
ENV_DIR=$3 | ||
BP_DIR=`cd $(dirname $0); cd ..; pwd` | ||
|
||
# Switch to new Node auto build behavior ahead of release | ||
export NEW_BUILD_SCRIPT_BEHAVIOR=true | ||
|
||
# Use architecture of multi-buildpack to compose behavior. | ||
# https://github.com/heroku/heroku-buildpack-multi | ||
cp $BP_DIR/.buildpacks $BUILD_DIR/.buildpacks | ||
|
@@ -31,21 +34,6 @@ branch="" | |
dir=$(mktemp -t buildpackXXXXX) | ||
rm -rf $dir | ||
|
||
echo "-----> Configure create-react-app build environment" | ||
# Set env vars for the inner buildpacks in `.buildpacks` | ||
# * during compile, install build tooling (devDependencies) with npm & Yarn | ||
# * in runtime, NODE_ENV is not used (this buildpack launches a static web server) | ||
export NPM_CONFIG_PRODUCTION=false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We used to export Ex: heroku/heroku-buildpack-nodejs#519 (comment) I don't think there's a way around this, just wanted to call it out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It felt real good deleting all the NPM/NODE env monkey business. Now this buildpack utilizes/acts like the Node buildpack as much as possible! |
||
INHERITED_NODE_ENV="${NODE_ENV:-development}" | ||
if [ "$INHERITED_NODE_ENV" = "production" ] | ||
then | ||
echo ' Setting `NODE_ENV=development` to install dependencies for `npm build`' | ||
export NODE_ENV=development | ||
else | ||
echo " Using \`NODE_ENV=${INHERITED_NODE_ENV}\`" | ||
export NODE_ENV="${INHERITED_NODE_ENV}" | ||
fi | ||
|
||
echo "=====> Downloading Buildpack: $url" | ||
|
||
if [[ "$url" =~ \.tgz$ ]] || [[ "$url" =~ \.tgz\? ]]; then | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.