feature: bridge transfer only #1094
Conversation
StefChatz
requested review from
bobthebuidlr,
linkielink and
Patricie29
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| getCosmosSigner: async () => { | ||
| const offlineSigner = window.keplr?.getOfflineSigner(chainConfig.id.toString()) | ||
| if (!offlineSigner) throw new Error('Keplr not installed') | ||
| return offlineSigner | ||
| }, |
There was a problem hiding this comment.
You should be able to get the offlineSigner from the useShuttle hook.
With this code in place, you limit yourself to the Keplr-based wallets Keplr and Leap. Metamask Snap and Vectis won't work, and neither will Cosmostation.
Please check the Shuttle documentation or contact Gustavo or André from Astroport to learn how to get the offline signer.
| } | ||
|
|
||
| try { | ||
| if (!selectedAsset.chain) throw new Error('Chain not found for selected asset') |
There was a problem hiding this comment.
Do you need to throw an error?
This will trigger the client-side error page on the app.
A console.log error would be enough. An error handling in the UI would be best.
| const usdcAssets = Object.entries(balances).map(([chainId, balance]) => | ||
| WrappedBNCoin.fromDenomAndBigNumber( | ||
| `ibc/4C19E7EC06C1AB2EC2D70C6855FEB6D48E9CE174913991DA0A517D21978E7E42`, | ||
| isTestnet | ||
| ? 'ibc/4C19E7EC06C1AB2EC2D70C6855FEB6D48E9CE174913991DA0A517D21978E7E42' | ||
| : 'ibc/B559A80D62249C8AA07A380E2A2BEA6E5CA9A6F079C912C3A9E9B494105E4F81', | ||
| BN(balance).shiftedBy(6), | ||
| CHAIN_NAMES[Number(chainId)], | ||
| ), |
There was a problem hiding this comment.
Please move this to the respective ChainConfig chains/[neutron or osmosis]/[chainId].ts file
This commit adds support for fetching asset images from the 'icons.llamao.fi' source in addition to the existing 'xdefi-static.s3.eu-west-1.amazonaws.com' source. This allows for a wider range of asset images to be displayed in the application. The 'Asset' component has been updated to conditionally render the new 'AssetImageEvm' component when the asset has a 'chainName' property. The 'AssetImageEvm' component displays the asset image along with the logo of the corresponding EVM chain. The 'getChainLogoByName' function has been added to the 'chainLogos.ts' file to retrieve the URL of the EVM chain logo based on the chain name. These changes improve the visual representation of assets in the application and enhance the user experience.
…dContent components
No description provided.