Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link has wrong hit area in VS Code 1.36-insider #45

Closed
yhatt opened this issue Jun 7, 2019 · 0 comments · Fixed by #49
Closed

Link has wrong hit area in VS Code 1.36-insider #45

yhatt opened this issue Jun 7, 2019 · 0 comments · Fixed by #49

Comments

@yhatt
Copy link
Member

yhatt commented Jun 7, 2019

The latest build of VS Code 1.36-insider has updated Electron from 3.x to 4.x.

Version: 1.36.0-insider
Commit: c089daa858f34631f5f827ff8a0313bf1e2ded6d
Date: 2019-06-07T06:13:41.194Z
Electron: 4.2.3
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 18.6.0

I have already known Chrome <= 69 still has a serious bug in rendering Marpit's inline SVG slide. (See marp-team/marpit#35 that I found a year ago)

Chrome 66 (Electron 3.x) cannot scale hit area and rendering by inline SVG. Only DevTool knows the actual scaled DOM. I had same issue in marp-team/marp-cli#15. Fortunately we can fix it by just applying a WebKit polyfill manually, so Marp for VS Code had used marpit-svg-polyfill.

In Chrome 69 (Electron 4.x), only the hit area is following correct scaling by inline SVG, and rendering is not. The polyfill should keep using to fix rendering, but hit area will too scaled.

electron4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant