Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math blocks don't scale #38

Closed
tosaba opened this issue May 14, 2019 · 3 comments
Closed

Math blocks don't scale #38

tosaba opened this issue May 14, 2019 · 3 comments

Comments

@tosaba
Copy link

tosaba commented May 14, 2019

For the current version, equations are not scaled anymore to fit the size of the slide. Probably this issue is related to marp-core functionality, but for me, this appears within vs-code.
In the documentation of marp-core, it's written that the auto-scaling does not work with the uncover-theme. I am using theme: default.
It does not matter whether any [bg right] image is included on the slide or not.

Thanks!

# Some title

Eq. that fits into one line (no block) 
$S_1 = C_0 + n S_3$


Eq. that doesn't fit into one line (block)
$$S_1-S_3 = C_0 + \left(1-n\right)P_p - \left(1-n\right)S_3$$

Eq. that doesn't fit into one line (no block)
$S_1-S_3 = C_0 + \left(1-n\right)P_p - \left(1-n\right)S_3$

![bg right](test.png)

image

@yhatt
Copy link
Member

yhatt commented May 14, 2019

As same as #8, it would be caused by a rendering bug in the old Chromium version in VS Code (Electron 3.x / Chrome 66). It displays correctly on VS Code for exploration (based on Electron 4.x / Chrome 69: microsoft/vscode#61787).

Diffrence between Electron 3 and 4

Waiting to update of VS Code is the only thing that we can do, but unfortunelly an update to Electron 4 is still blocked (microsoft/vscode#61787 (comment)).

For a while, use Marp CLI's preview mode as a workaround.

npx @marp-team/marp-cli --preview your-markdown.md

@yhatt yhatt added the upstream Depended on upstream label May 15, 2019
@yhatt
Copy link
Member

yhatt commented Jun 7, 2019

Now VS Code 1.36-insider is using Electron 4. It would resolve scaling issue. (But there is another issue: #45)

@yhatt yhatt removed the upstream Depended on upstream label Jun 13, 2019
@yhatt
Copy link
Member

yhatt commented Jul 3, 2019

Now VS Code v1.36 reaches to stable.

@yhatt yhatt closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants