Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding base url through baseUrl option #343

Merged
merged 6 commits into from
May 6, 2021
Merged

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented May 6, 2021

Allow setting custom URL for href attribute of <base> element in the template. By this change, Marp CLI can refer to the other server for resources while Puppeteer conversion.

For example, we may provide more secure conversion without using --allow-local-files flag by creating localhost proxy server referring restricted local resources. In the case of Marp for VS Code, it might be able to provide PDF conversion support in the virtual workspace. (marp-team/marp-vscode#224)

⚠️ This option is currently internal setting for collaboration with Marp for VS Code. It is not intended using by the consumer and the result of conversion may break if set wrong base URL.

@yhatt yhatt merged commit bd41a25 into main May 6, 2021
@yhatt yhatt deleted the base-url-config branch May 6, 2021 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant