Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing --allow-local-files option on WSL environment #182

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

yhatt
Copy link
Member

@yhatt yhatt commented Nov 7, 2019

Marp CLI does not render local file assets in WSL environment even if --allow-local-files option is enabled.

We are using Puppeteer to convert Markdown into PDF, PPTX, and images through Windows Chrome, so tmp file has to resolve base path into WSL.

@yhatt yhatt added the bug Something isn't working label Nov 7, 2019
@yhatt yhatt merged commit cee7428 into master Nov 7, 2019
@yhatt yhatt deleted the wsl-local-files branch November 7, 2019 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant