Fix ReferenceInput in ArrayInput #9882
Merged
+129
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When rendering a ReferenceInput inside an ArrayInput, the current value is never fetched.
Analysis
The current value is grabbed by
useReferenceInputController
as follows:The problem is, the source is no longer modified by the parent ArrayInput. So when using:
ReferenceInput will get the current value from
product_id
instead ofbasket.0.product_id
.cf
react-admin/packages/ra-core/src/controller/input/useReferenceInputController.ts
Line 71 in 51e8a7c
Solution
Use the
useWrappedSource
hookTo Do
<ReferenceInput>
<ReferenceArrayInput>