Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint warning in *Hard coded local username/password* template of create-react-admin #9728

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

hbendev
Copy link
Contributor

@hbendev hbendev commented Mar 16, 2024

Ignore @typescript-eslint scoped rule for local auth provider template file.

Ignore @typescript-eslint scoped rule for local auth provider template file.
@hbendev
Copy link
Contributor Author

hbendev commented Mar 16, 2024

Hi! Thanks for the framework! When using the create-react-admin CLI, and selecting Hard coded local username/password option this generated line is marked as an error by ESLint if the configuration extends "plugin:@typescript-eslint/recommended".

If you see any value in these, I'm happy to

  1. Address this extra additional disabled rule in other template files.
  2. Change the default generated ESLint configuration to extend upon the @typescript-eslint/recommended values.

@djhi
Copy link
Collaborator

djhi commented Apr 12, 2024

Thanks!

@djhi djhi added this to the 4.16.16 milestone Apr 12, 2024
@djhi djhi merged commit 3214e91 into marmelab:master Apr 12, 2024
8 checks passed
@djhi djhi changed the title Update authProvider.ts Fix eslint warning in *Hard coded local username/password* template of create-react-am Apr 12, 2024
@djhi djhi changed the title Fix eslint warning in *Hard coded local username/password* template of create-react-am Fix eslint warning in *Hard coded local username/password* template of create-react-admin Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants