Introduce ReferenceInputBase Components #9672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
force-pushed
the
reference-components-core
branch
from
393ad9d
to
ccea8b8
Compare
djhi
changed the title
djhi
commented
Mar 5, 2024
packages/ra-core/src/controller/input/ReferenceInputBase.spec.tsx
Outdated
Show resolved
Hide resolved
adguernier
requested changes
Mar 5, 2024
packages/ra-core/src/controller/input/ReferenceInputBase.stories.tsx
Outdated
Show resolved
Hide resolved
adguernier
reviewed
Mar 5, 2024
adguernier
approved these changes
Mar 5, 2024
erwanMarmelab
approved these changes
Mar 6, 2024
fzaninotto
requested changes
Mar 7, 2024
| export interface ReferenceInputBaseProps | ||
| extends InputProps, | ||
| UseReferenceInputControllerParams { | ||
| children: ReactNode; |
There was a problem hiding this comment.
I'd make it optional, to avoid overriding the interface in the ReferenceInput component
packages/ra-core/src/controller/input/ReferenceInputBase.stories.tsx
Outdated
Show resolved
Hide resolved
packages/ra-core/src/controller/input/ReferenceInputBase.spec.tsx
Outdated
Show resolved
Hide resolved
fzaninotto
requested changes
Apr 5, 2024
Comment on lines
97
to
98
| extends Omit<ReferenceInputBaseProps, 'children'> { | ||
| children?: ReactNode; |
There was a problem hiding this comment.
No longer necessary as you edited the RefrenceInputBaseProps type
fzaninotto
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While working on the alternative UI libraries demos, we had to re-implement all the reference fields and inputs logic.
Solution
Add core headless versions for these components
This PR introduces only the
ReferenceInputBase.