Fix Datagrid Header Sort Tooltip #9605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem In a `<Datagrid>`, the header of sortable columns has a tooltip that is the same for all columns: "Sort". It's not explicit enough, and it's even confusing for screen readers. ## Solution Reuse the title logic from `<SortButton>`, which already solves this problem. Closes #9541
fzaninotto
commented
Jan 23, 2024
| @@ -272,7 +272,9 @@ describe('<Datagrid />', () => { | |||
| it('should display a message when there is no result', () => { | |||
| render( | |||
| <Wrapper listContext={{ ...contextValue, data: [], total: 0 }}> | |||
| <Datagrid /> | |||
| <Datagrid> | |||
| <TitleField /> | |||
There was a problem hiding this comment.
unrelated change, but the missing child was causing a warning in the test output
slax57
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In a
<Datagrid>, the header of sortable columns has a tooltip that is the same for all columns: "Sort". It's not explicit enough, and it's even confusing for screen readers.Solution
Reuse the title logic from
<SortButton>, which already solves this problem.Closes #9541