Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix StackedFilters usage examples #9345

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

mchaffotte
Copy link
Contributor

@mchaffotte mchaffotte commented Oct 9, 2023

Problem

The examples showing how to use do not explain well. They do not use the right prop.

    <List
      filters={
        <StackedFilters config={documentsListFilters} />
      }
    >

It should be:

    <List
      actions={
        <TopToolbar>
          <StackedFilters config={documentsListFilters} />
          <ExportButton />
        </TopToolbar>
      }
    >

Solution

Update the documentation

Todo

  • update documentation

@fzaninotto
Copy link
Member

Can you please update the PR description? "The examples are wrong" doesn't explain the problem.

@slax57 slax57 added this to the 4.14.6 milestone Oct 9, 2023
@slax57 slax57 merged commit 0beb2d3 into master Oct 9, 2023
5 checks passed
@slax57 slax57 deleted the fix-stacked-filter-doc branch October 9, 2023 13:14
@slax57 slax57 changed the title [doc] show how to use StackedFilters well [Doc] Fix StackedFilters usage examples Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants