Fix useUnique send request even if the field value is empty #9334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Oct 5, 2023
djhi
requested changes
Oct 6, 2023
| @@ -87,6 +87,9 @@ export const useUnique = (options?: UseUniqueOptions) => { | |||
| ); | |||
|
|
|||
| return async (value: any, allValues: any, props: InputProps) => { | |||
| if (!value) { | |||
There was a problem hiding this comment.
Can you extract and use 'isEmptyfromvalidate.ts` instead?
djhi
approved these changes
Oct 6, 2023
djhi
deleted the
fix-use-unique-send-request-even-tested-field-is-empty
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
While using
useUniquein an non required input, and when sending the form with empty value within this input,useUniquesearch for data withnullvalue and returns results that indicates the record is not unique and indeed, cause errors on form.This issue happens with some DBMS and DataProvider
Solution
Do not send request to the API if value tested by useUnique is empty.
Todo
isEmptyfunction to check if the tested input is empty