[Doc] Refactor Theming documentation #9193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Aug 17, 2023
| <TrueIcon | ||
| data-testid="true" | ||
| fontSize="small" | ||
| className={classes.trueIcon} |
There was a problem hiding this comment.
This unrelated change was necessary for an example in the SX documentation
fzaninotto
commented
Aug 17, 2023
docs/css/style-v18.css
Outdated
There was a problem hiding this comment.
These changes fix the TOC, which was too small once readers scroll down on a page and hide the app bar.
fzaninotto
commented
Aug 17, 2023
|
|
||
| ## `sx`: Overriding A Component Style |
There was a problem hiding this comment.
All removed sections are present elsewhere. I checked ;)
fzaninotto
commented
Aug 18, 2023
|
|
||
| ## Loading |
There was a problem hiding this comment.
Except Loading and LinearProgress, which were poorly documente anyway
djhi
requested changes
Aug 18, 2023
adguernier
reviewed
Aug 18, 2023
Co-authored-by: Gildas Garcia <1122076+djhi@users.noreply.github.com> Co-authored-by: adrien guernier <adrien@marmelab.com>
adguernier
reviewed
Aug 18, 2023
Co-authored-by: adrien guernier <adrien@marmelab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Solution
A dedicated Theming doc section with several chapters.
To do