Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Convert List Tutorial Examples to TS #9181

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Aug 14, 2023

  • Fix Pagination Props Type
  • Rewrite List Tutorial Examples in TS

Comment on lines 238 to 240
<Datagrid data={data} sort={sort}>
<Datagrid>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change must be in the diff

docs/ListTutorial.md Show resolved Hide resolved
field,
order: field === sort.field ? inverseOrder(sort.order) : 'ASC'
});
if (field) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation problem?

@fzaninotto fzaninotto changed the title Rewrite List Tutorial Examples in TS [Doc] Convert List Tutorial Examples to TS Aug 14, 2023
@fzaninotto fzaninotto merged commit 49b6f10 into master Aug 14, 2023
8 checks passed
@fzaninotto fzaninotto deleted the ts-documentation-list-tutorial branch August 14, 2023 16:23
@fzaninotto fzaninotto added this to the 4.13.1 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants