Update <Confirm> to accept a React node as confirmTitle or confirmContent
#9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slax57
requested changes
Jul 21, 2023
slax57
changed the title
confirmTitle or confirmContent in buttons with a confirmation dialog
fzaninotto
changed the title
confirmTitle or confirmContent in buttons with a confirmation dialog<Confirm> to accept a React node as confirmTitle or confirmContent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Buttons with confirmation Dialog for
confirmTitleprop accepts onlystringtype, which make not possible for customization.In this PR I changed type to
React.ReactNode, also I fixed PropTypes value forconfirmContentas it was conflicted with TS types and errored in App console.This PR resolves these issues: #9113, #9105