Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize <AutocompleteInput>'s filterToQuery and improve <AutocompleteInput> and <AutocompleteArrayInput>'s docs about props stability #9046

Merged
merged 4 commits into from
Jul 3, 2023
Merged

Memoize <AutocompleteInput>'s filterToQuery and improve <AutocompleteInput> and <AutocompleteArrayInput>'s docs about props stability #9046

merged 4 commits into from
Jul 3, 2023

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Jun 26, 2023

No description provided.

@djhi djhi added the RFR Ready For Review label Jun 26, 2023
@djhi
Copy link
Collaborator Author

djhi commented Jun 26, 2023

Fixes #8545

slax57
slax57 requested changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the title of the PR is misleading, because you also changed something in the code, not only the docs

docs/AutocompleteArrayInput.md Show resolved Hide resolved
docs/AutocompleteArrayInput.md Outdated Show resolved Hide resolved
@slax57 slax57 added this to the 4.11.5 milestone Jul 3, 2023
@slax57 slax57 merged commit 8e12cfd into master Jul 3, 2023
@slax57 slax57 deleted the fix-autocompletearrayinput-glitches branch July 3, 2023 13:33
@slax57 slax57 changed the title Update documentation about AutocompleteInput and AutocompleteArrayInput Memoize <AutocompleteInput>'s filterToQuery and improve <AutocompleteInput> and <AutocompleteArrayInput>'s docs about props stability Jul 3, 2023
@slax57 slax57 modified the milestones: 4.11.5, 4.12.0 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slax57 slax57 slax57 approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @slax57