Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] fix examples of custom UserMenu items across the docs to support keyboard navigation #8837

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Apr 17, 2023

Some of the examples of custom <UserMenu /> items does not pass down the ref, so MUI cannot manage keyboard navigation under this case.

docs/AppBar.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@smeng9 smeng9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix types

@fzaninotto
Copy link
Member

Can you also please add a description of the bug you're fixing and how to reproduce it in the PR description?

@smeng9
Copy link
Contributor Author

smeng9 commented Apr 24, 2023

Hi @fzaninotto I have added a short description of the documentation issue that I am trying to fix

@smeng9 smeng9 changed the title [Doc] fix examples of custom UserMenu items across the docs [Doc] fix examples of custom UserMenu items across the docs to support keyboard navigation Apr 24, 2023
Copy link
Contributor

@slax57 slax57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slax57 slax57 merged commit dbb8ba3 into marmelab:master Apr 24, 2023
@djhi djhi added this to the 4.9.4 milestone Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants