feat(input): full width on low screen resolution #8797
Conversation
|
I am not sure about what fix to provide for the typecheck issue. May you give me a hint? I followed that documentation: https://mui.com/material-ui/customization/theme-components/#theme-style-overrides |
It's odd, but it seems that, although this syntax is documented, MUI is not willing to support it in the long term and hence not willing to support it in the TS types (source: mui/material-ui#29319) You might have to find another way to do this... |
|
@slax57 Thanks! That is quite a bad news because the other found I started to get into was to add the According to that comment, we may be able to achieve our needs using |
soullivaneuh
force-pushed
the
input-full-width-small-resolution
branch
from
5e46989
to
527eeaa
Compare
|
I got that fixed using variants! 🎉 As the usage of |
| variants: [ | ||
| { | ||
| props: {}, | ||
| style: { | ||
| backgroundColor: 'rgba(0, 0, 0, 0.04)', | ||
| '&$disabled': { | ||
| backgroundColor: 'rgba(0, 0, 0, 0.04)', | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Can you explain why you needed to change these lines too?
There was a problem hiding this comment.
Please see: #8797 (comment)
As the usage of styleOverrides looks not recommended for the future, I also took the initiative to migrate the existing on a separated commit: b217bb6
If you prefer to keep the change to the target, I can simply drop this commit. 👍
There was a problem hiding this comment.
Oh I see. Actually my understanding is that it's only the API for supporting callback in styleOverrides which may not be supported long term, but not the whole styleOverrides feature.
So IMO there's no need to change that.
There was a problem hiding this comment.
This is something not needed currently but may be needed if we want dynamic styling as I did for the rest later.
As using style handles both cases (static and dynamic), transforming it make it ready for.
If you still disagree with my opinion, please let me know and I will confirm by removing the commit.
|
This PR doesn't fix the aforementioned problem, see the deployed storybook https://react-admin-storybook-jxzza3gyv-marmelab.vercel.app/?path=/story/ra-ui-materialui-list-list--filters
|
|
No news for some time, closing. |
|
Superseded by #9169 |
Summary
closes #8795