Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cannot override Create and Edit buttons style with a theme #8624

Merged

Conversation

IAmVisco
Copy link
Contributor

@IAmVisco IAmVisco commented Feb 6, 2023

Closes #8623

@fzaninotto
Copy link
Member

tests fail

@IAmVisco
Copy link
Contributor Author

IAmVisco commented Feb 7, 2023

Yeah I noticed and running 'em locally to check atm👍

@IAmVisco
Copy link
Contributor Author

IAmVisco commented Feb 7, 2023

@fzaninotto could you approve the workflows again please?

@fzaninotto fzaninotto merged commit a69ba1f into marmelab:master Feb 7, 2023
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto changed the title Add classnames to Create and Edit buttons Fix cannot override Create and Edit buttons style with a theme Feb 7, 2023
@fzaninotto fzaninotto added this to the 4.8.0 milestone Feb 7, 2023
@IAmVisco IAmVisco deleted the bugfix/add-classes-to-special-buttons branch February 7, 2023 12:40
@fzaninotto fzaninotto modified the milestones: 4.8.0, 4.7.5 Feb 10, 2023
@slax57
Copy link
Contributor

slax57 commented Feb 20, 2023

@davidhenley Nope, we are not aware of such a bug.
I just had a look at the simple example stackblitz but I see nothing wrong there.
If you manage to reproduce in this example, feel free to open a new issue!

@davidhenley
Copy link
Contributor

davidhenley commented Feb 20, 2023

Hey @slax57 I figured it out. I had something in the theme overrides that I guess just started "working" (failing) with this commit.

RaCreateButton: {
  styleOverrides: {
    root: {
      display: 'none'
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RaCreateButton overrides have no effect
4 participants