Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix performance issue in useGetList and useGetManyReferences #8174

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

djhi
Copy link
Collaborator

@djhi djhi commented Sep 16, 2022

Since the hook always returns a new object, this causes unwanted rerenders that can cascade and harm performance.

Copy link
Contributor

@WiXSL WiXSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@fzaninotto fzaninotto merged commit d1b63eb into master Sep 16, 2022
@fzaninotto fzaninotto deleted the fix-usegetlist-and-usegetmanyreferences-results branch September 16, 2022 11:41
@fzaninotto fzaninotto changed the title Fix useGetList and useGetManyReferences build new result object at each call Fix performance issue in useGetList and useGetManyReferences Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants