Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Fix missing import in Routing chapter #8164

Merged
merged 1 commit into from
Sep 15, 2022
Merged

[Doc] Fix missing import in Routing chapter #8164

merged 1 commit into from
Sep 15, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Sep 14, 2022 •
edited
Loading

@WiXSL WiXSL added the RFR Ready For Review label Sep 14, 2022
@WiXSL
Copy link
Contributor

WiXSL commented Sep 14, 2022

Thanks!

@fzaninotto fzaninotto merged commit c7b2279 into marmelab:master Sep 15, 2022
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 4.3.3 milestone Sep 15, 2022
@fzaninotto fzaninotto changed the title Add missing Route import to Routing docs example [Doc] Fix missing import in Routing chapter Sep 15, 2022
@herndlm herndlm deleted the patch-1 branch September 15, 2022 07:07
@herndlm
Copy link
Contributor Author

herndlm commented Sep 15, 2022

btw offtopic, the 3 -> 4 upgrade docs are really good and well-written :)

@fzaninotto
Copy link
Member

Thanks for the feedback, we appreciate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WiXSL WiXSL WiXSL approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@herndlm @WiXSL @fzaninotto