Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hide <Logout /> button if irrelevant. #7842

Merged
merged 4 commits into from
Jun 17, 2022
Merged

Fix Hide <Logout /> button if irrelevant. #7842

merged 4 commits into from
Jun 17, 2022

Conversation

antoinefricker
Copy link
Contributor

Closes #7839

Hide logout button if irrelevant.

fzaninotto
fzaninotto requested changes Jun 16, 2022
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you're missing a unit test...

examples/simple/src/posts/PostList.tsx Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/auth/Logout.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – react-admin June 16, 2022 14:01 Inactive
@vercel vercel bot temporarily deployed to Preview – react-admin June 17, 2022 05:37 Inactive
@antoinefricker antoinefricker added the RFR Ready For Review label Jun 17, 2022
@fzaninotto
Copy link
Member

Awesome! Just fix the linter warning and we're good to merge.

@vercel vercel bot temporarily deployed to Preview – react-admin June 17, 2022 07:33 Inactive
@djhi djhi added this to the 4.1.4 milestone Jun 17, 2022
@djhi djhi merged commit c4931aa into master Jun 17, 2022
@djhi djhi deleted the 7839-login-logout branch June 17, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

@slax57 slax57 slax57 approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
4.1.4
Development

Successfully merging this pull request may close these issues.

User panel displays a misleading "Logout" invite when user is not logged in.
4 participants
@antoinefricker @fzaninotto @djhi @slax57