Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix Form Validation section mentions ability to do both async validation per input and global validation #7726

Merged
merged 1 commit into from
May 23, 2022

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented May 20, 2022

Related to #7697

@@ -282,7 +282,7 @@ const emailValidators = [required(), validateEmailUnicity];

export const UserCreate = () => (
<Create>
<SimpleForm validate={validateUserCreation}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The validateUserCreation does not exist in this example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

@soullivaneuh
Copy link
Contributor

soullivaneuh commented May 20, 2022

@slax57 In my opinion, this should not reference the issue as fixes because it will lead to auto-close. However, we agreed that the validator combination should be a thing: #7697 (comment)

@djhi djhi added this to the 4.1.1 milestone May 23, 2022
@djhi djhi merged commit b1c1236 into master May 23, 2022
@djhi djhi deleted the doc-fix-async-validation branch May 23, 2022 07:27
@fzaninotto fzaninotto changed the title Doc: Fix Async Validation per Input example [Doc] Fix Form Validation section mentions ability to do both async validation per input and global validation May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants