Fix failing admin test when running all tests together #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test otherwise often fails when running all tests. If only running this test it needs just below the default 5000ms.
If this is not set here, IDE tools such as VS Code will load all typescript definitions from all node_modules in the tree. Since both jest and mocha are in the root node_modules folder and each of them have a declaration for the describe and it function used in our tests, it doesn't know which one to take and intellisense is wrong. This is a common issue in a monorepo using workspaces where all dependencies of all packages are hoisted in the root folder.
|
Thanks, I really like this one! |
WiXSL
approved these changes
Jan 25, 2022
fzaninotto
approved these changes
Jan 25, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that on my machine this test always failed with a timeout exception when running
yarn test-unitin the root project.It did not fail however when running
yarn test-unit --watchbecause then it took just below the default 5000ms timeout setting of jest.I have increased the timeout for this specific test and applied some best practices for this test.
I've also fixed the incorrect intellisense for the test files by explicitly setting
jestin the required types in tsconfig.json so it doesn't look at mochas typescript definition files any longer.